SteNicholas commented on code in PR #3592:
URL: https://github.com/apache/celeborn/pull/3592#discussion_r2757358128
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/ChannelsLimiter.java:
##########
@@ -130,7 +130,7 @@ public void userEventTriggered(ChannelHandlerContext ctx,
Object evt) {
@Override
public void onPause(String moduleName) {
if (this.moduleName.equals(moduleName)) {
- logger.info("{} channels pause read.", this.moduleName);
+ logger.debug("{} channels pause read.", this.moduleName);
Review Comment:
Please revert this unnecessary change.
##########
tests/spark-it/src/test/resources/log4j2-test.xml:
##########
@@ -21,7 +21,7 @@
<Console name="stdout" target="SYSTEM_OUT">
<PatternLayout pattern="%d{yy/MM/dd HH:mm:ss,SSS} %p [%t] %c{1}:
%m%n%ex"/>
<Filters>
- <ThresholdFilter level="ERROR"/>
+ <ThresholdFilter level="INFO"/>
Review Comment:
Why change the log level?
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -231,6 +232,13 @@ public ShuffleClientImpl(String appUniqueId, CelebornConf
conf, UserIdentifier u
reviveManager = new ReviveManager(this, conf);
+ if (conf.hasS3Storage()) {
Review Comment:
Does the OSS storage have the same behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
