eolivelli commented on code in PR #3592:
URL: https://github.com/apache/celeborn/pull/3592#discussion_r2757734142
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -231,6 +232,13 @@ public ShuffleClientImpl(String appUniqueId, CelebornConf
conf, UserIdentifier u
reviveManager = new ReviveManager(this, conf);
+ if (conf.hasS3Storage()) {
Review Comment:
we could do this check for all the external storage types
I did it only for S3 but we can loop over the available types and perform
the check
I am not familiar with the other types, but the intent here is to prevent
the client to start if it is misconfigured (you will see a null pointer
exception later if you don't configure it properly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
