eolivelli commented on code in PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#discussion_r2797894178
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -147,6 +146,25 @@ class StoragePolicy(conf: CelebornConf, storageManager:
StorageManager, source:
partitionDataWriterContext,
storageManager)
} else {
+ null
Review Comment:
I suggest to add logDebug for these cases that return "null", sometimes I
saw errors and I did not understand the reason
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -1213,9 +1170,80 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
}
retryCount += 1
}
+ if (dfsStorageAvailable) {
+ logWarning("Failed to create localFileWriter", exception)
Review Comment:
please report shuffleId
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -158,10 +176,10 @@ class StoragePolicy(conf: CelebornConf, storageManager:
StorageManager, source:
diskFileInfo.getStorageType,
partitionDataWriterContext,
storageManager)
+ } else {
+ null
Review Comment:
also here and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
