eolivelli commented on code in PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#discussion_r2811130226
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -1213,9 +1170,80 @@ final private[worker] class StorageManager(conf:
CelebornConf, workerSource: Abs
}
retryCount += 1
}
+ if (dfsStorageAvailable) {
+ logWarning("Failed to create localFileWriter", exception)
+ return (null, null, null)
+ }
throw exception
}
+ def createDfsDiskFile(
+ location: PartitionLocation,
+ appId: String,
+ shuffleId: Int,
+ fileName: String,
+ userIdentifier: UserIdentifier,
+ partitionType: PartitionType,
+ partitionSplitEnabled: Boolean): (Flusher, DiskFileInfo, File) = {
+ val shuffleKey = Utils.makeShuffleKey(appId, shuffleId)
+ if (location.getStorageInfo.HDFSAvailable()) {
Review Comment:
I think that the better solution looks like this:
https://github.com/Qbeast-io/celeborn/commit/460fc9b12ef1a523b565cd3df31254db1d7bf373#diff-332230b33db740720657fd9c90e4f4eb0bce18b43f4749fddfe37463cc11a9b1R1125-R1128
we have to decouple the storage type to use from the "location"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
