eolivelli commented on code in PR #3608:
URL: https://github.com/apache/celeborn/pull/3608#discussion_r2838135900
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -260,8 +260,12 @@ private static StorageInfo getStorageInfo(
storageInfo = new StorageInfo("", StorageInfo.Type.S3,
availableStorageTypes);
} else if (StorageInfo.OSSAvailable(availableStorageTypes)) {
storageInfo = new StorageInfo("", StorageInfo.Type.OSS,
availableStorageTypes);
- } else {
+ } else if (StorageInfo.HDFSAvailable(availableStorageTypes)) {
storageInfo = new StorageInfo("", StorageInfo.Type.HDFS,
availableStorageTypes);
+ } else if (StorageInfo.memoryAvailable(availableStorageTypes)) {
Review Comment:
this change is not strictly needed by this patch
but in some error conditions (in case I force the test to fail), when using
MEMORY storage, you see PartitionLocations assigned to HDFS, even if HDFS is
not configured.
I can move this to another PR, but I think it's relevant to this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
