eolivelli commented on code in PR #3608:
URL: https://github.com/apache/celeborn/pull/3608#discussion_r2841863492
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/SlotsAllocator.java:
##########
@@ -260,8 +260,12 @@ private static StorageInfo getStorageInfo(
storageInfo = new StorageInfo("", StorageInfo.Type.S3,
availableStorageTypes);
} else if (StorageInfo.OSSAvailable(availableStorageTypes)) {
storageInfo = new StorageInfo("", StorageInfo.Type.OSS,
availableStorageTypes);
- } else {
+ } else if (StorageInfo.HDFSAvailable(availableStorageTypes)) {
storageInfo = new StorageInfo("", StorageInfo.Type.HDFS,
availableStorageTypes);
+ } else if (StorageInfo.memoryAvailable(availableStorageTypes)) {
Review Comment:
I added unit tests to cover this method.
this is indeed important because with the new unit tests we are sealing the
behavior of the master choosing the storage types depending on the specs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
