xumingming commented on code in PR #3672:
URL: https://github.com/apache/celeborn/pull/3672#discussion_r3232894704
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -184,6 +174,26 @@ public void write(scala.collection.Iterator<Product2<K,
V>> records) throws IOEx
}
}
+ boolean doWrite(scala.collection.Iterator<Product2<K, V>> records)
Review Comment:
some of the doWrite(s) is called from testing
code(SortBasedShuffleWriterSuiteJ), so I'd prefer keep all doWrite(...)
package-private to be consistent and simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
