xumingming commented on code in PR #3672:
URL: https://github.com/apache/celeborn/pull/3672#discussion_r3232907696
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -359,6 +369,8 @@ private void close() throws IOException,
InterruptedException {
updateMapStatus();
+ SparkUtils.assertIteratorFullyConsumed(iteratorHasNext);
+
sendBufferPool.returnBuffer(sendBuffers);
sendBuffers = null;
sendOffsets = null;
Review Comment:
This is a good catch. I have moved SparkUtils.assertIteratorFullyConsumed
down to the line just above "shuffleClient.mapperEnd", so after the changes:
- All resources are cleaned before we kill the task.
- The MapperEnd event is not submit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
