RexXiong commented on PR #3698: URL: https://github.com/apache/celeborn/pull/3698#issuecomment-4534663322
**Overall**: Clean, well-scoped change. The decommission-on-SIGTERM approach is the right abstraction for scale-down — avoids requiring custom preStop scripts. The Copilot/SteNicholas feedback has been addressed well (explicit timeout registration, `WORKER_DECOMMISSION` exit kind, assertion order fix, config override test). **Config version should likely be `0.7.0`** The new config `celeborn.worker.decommission.shutdown.enabled` is versioned `0.6.0`, but other new configs in recent PRs (e.g., PR #3695) use `0.7.0`. If `main` is targeting 0.7.0, this should be updated to match. *Reviewed with Claude Code* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
