Copilot commented on code in PR #3698: URL: https://github.com/apache/celeborn/pull/3698#discussion_r3308559981
########## common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala: ########## @@ -1357,7 +1357,9 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable with Logging with Se // ////////////////////////////////////////////////////// // Graceful Shutdown & Recover // // ////////////////////////////////////////////////////// - def workerGracefulShutdown: Boolean = get(WORKER_GRACEFUL_SHUTDOWN_ENABLED) + def workerDecommissionShutdownEnabled: Boolean = get(WORKER_DECOMMISSION_SHUTDOWN_ENABLED) Review Comment: `CelebornConf.workerGracefulShutdown` appears to have been removed/renamed to `workerGracefulShutdownEnabled`. Since `CelebornConf` is a public config API and these accessors are callable from both Scala and Java, this is a source-compatibility break for any downstream code still calling the old method. Consider keeping `workerGracefulShutdown` as a deprecated alias delegating to `workerGracefulShutdownEnabled` (and similarly keep the Java-accessible method signature) to preserve compatibility while introducing the new override semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
