pltbkd commented on PR #3718: URL: https://github.com/apache/celeborn/pull/3718#issuecomment-4618505955
Overall LGTM. The only concern is that map partition reuses `readReducerPartitionEnd`, along with `PbReadReducerPartitionEnd` and `READ_REDUCER_PARTITION_END_FAILED`, which will probably be confusing in the future. I'd recommend renaming to the `readPartitionEnd` series, but there are possibly compatibility issues. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
