SteNicholas commented on code in PR #3718:
URL: https://github.com/apache/celeborn/pull/3718#discussion_r3354586073
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -559,7 +564,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
StatusCode.SUCCESS.getValue).build()
} else {
response = PbReadReducerPartitionEndResponse.newBuilder().setStatus(
-
+StatusCode.READ_REDUCER_PARTITION_END_FAILED.getValue).setErrorMsg(errorMessage).build()
Review Comment:
@xumingming, it was a stray unary plus
(`+StatusCode.READ_REDUCER_PARTITION_END_FAILED.getValue`). Unary `+` on an
`Int` is a no-op in Scala, so it had no effect — almost certainly an accidental
leftover from the original CELEBORN-894 change. This PR just removes it
(cosmetic, no behavior change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
