afterincomparableyum opened a new pull request, #3736:
URL: https://github.com/apache/celeborn/pull/3736
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
A worker serializes an empty RoaringBitmap as an empty protobuf bytestring,
and Utils.byteStringToRoaringBitmap deserializes empty bytes back to null. That
null was stored in CommitFilesResponse.committedMapIdBitMap (a HashMap, which
allows null values) and then merged into the ConcurrentHashMap
ShuffleCommittedInfo.committedMapIdBitmap via putAll, which rejects null values
and throws NPE in processResponse.
Since ReducePartitionCommitHandler.tryFinalCommit had no try/finally, the
shuffle was left in inProcessStageEndShuffleSet and setStageEnd was never
called, so every GetReducerFileGroup request parked until the executor RPC
timeout, hanging the spark client process.
Fixes:
- ControlMessages: skip null bitmaps when deserializing CommitFilesResponse
so null never reaches the ConcurrentHashMap.putAll.
- ReducePartitionCommitHandler: wrap the commit in try/finally so the
in-process stage-end marker is always cleared, allowing retry.
- CelebornInputStream.skipLocation: treat a null mapId bitmap as "do not
skip", guarding against the same empty->null round-trip in the read path.
I added a UtilsSuite regression test asserting a CommitFilesResponse with an
empty bitmap survives the transport round-trip without null map values.
### Why are the changes needed?
Without this, spark clients can hang for a really long time and see lots of
NPE errors.
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [ ] Yes
### How was this patch tested?
CI/CD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
