chenghuichen commented on PR #3698: URL: https://github.com/apache/celeborn/pull/3698#issuecomment-4714465167
The real bugs are fixed; the remaining points are intentional tradeoffs for an opt-in flag, as noted above. One ask for future rounds: please reconcile suggestions against the full review history. The hook-timeout registration, for instance, has now round-tripped **4-arg → `updateTimeout` → 4-arg** across reviews — the current explicit 4-arg form is a deliberate decision and I won't flip it again. I'm glad to address concrete correctness issues, but for an opt-in flag I'd like to keep the scope bounded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
