AmandeepSingh285 commented on code in PR #3740:
URL: https://github.com/apache/celeborn/pull/3740#discussion_r3504543459
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -75,12 +75,14 @@ private[celeborn] class Master(
new ResourceConsumptionSource(conf, Role.MASTER)
private val threadPoolSource = ThreadPoolSource(conf, Role.MASTER)
private val masterSource = new MasterSource(conf)
+ private val applicationMetricsSource = new ApplicationMetricsSource(conf)
private val jvmSource = new JVMSource(conf, Role.MASTER)
private val jvmCpuSource = new JVMCPUSource(conf, Role.MASTER)
private val systemMiscSource = new SystemMiscSource(conf, Role.MASTER)
metricsSystem.registerSource(resourceConsumptionSource)
metricsSystem.registerSource(masterSource)
+ metricsSystem.registerSource(applicationMetricsSource)
Review Comment:
@SteNicholas made a change to the approach where users can pass the labels
required with the metrics and they are used as tags instead of appid. This
helps avoid cardinality constraints. Could you please help with a review for
this approach. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
