AmandeepSingh285 commented on code in PR #3740:
URL: https://github.com/apache/celeborn/pull/3740#discussion_r3535830814
##########
client/src/test/scala/org/apache/celeborn/client/WorkerStatusTrackerSuite.scala:
##########
@@ -159,6 +160,31 @@ class WorkerStatusTrackerSuite extends CelebornFunSuite {
errors.get())
}
+ test("recordWorkerFailure increments client worker-excluded counter and
gauge") {
Review Comment:
Updated
##########
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala:
##########
@@ -42,10 +43,14 @@ class ApplicationHeartbeater(
(Long, Long, Map[String, java.lang.Long], Map[String,
java.lang.Long])),
workerStatusTracker: WorkerStatusTracker,
registeredShuffles: ConcurrentHashMap.KeySetView[Int, java.lang.Boolean],
- cancelAllActiveStages: String => Unit) extends Logging {
+ cancelAllActiveStages: String => Unit,
+ clientMetrics: () => util.Map[String, ClientMetric] =
+ () => new util.HashMap[String, ClientMetric]()) extends Logging {
Review Comment:
Updated
##########
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala:
##########
@@ -85,7 +90,10 @@ class ApplicationHeartbeater(
tmpApplicationFallbackCounts.asJava,
workerStatusTracker.getNeedCheckedWorkers().toList.asJava,
ZERO_UUID,
- true)
+ true,
+ if (appMetricLabels.isEmpty) new util.HashMap[String,
ClientMetric]()
+ else clientMetrics(),
+ appMetricLabels)
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
