cxzl25 commented on code in PR #3757:
URL: https://github.com/apache/celeborn/pull/3757#discussion_r3559282149
##########
project/CelebornBuild.scala:
##########
@@ -705,6 +704,14 @@ object CelebornCommon {
Dependencies.bouncycastleBcprovJdk18on,
Dependencies.bouncycastleBcpkixJdk18on
) ++ commonUnitTestDependencies,
+ // maven-jdk-tools-wrapper (jdkTools) only provides jdk.tools
(tools.jar) on
+ // JDK 8; on JDK 9+ the tools API is built into the JDK, so the wrapper
is a
+ // no-op there. Gate it to JDK 8 to match the `JDKTools` plugin
+ // (project/JDKTools.scala) and the Maven `jdk-8` profile, and to keep
the
+ // sbt/maven classpaths in sync (see dev/dependencies.sh).
+ libraryDependencies ++=
Review Comment:
If Flink2.3 uses sbt, it will bring additional maven-jdk-tools-wrapper
dependency, which is wrong. This issue is fixed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
