cxzl25 commented on code in PR #3757:
URL: https://github.com/apache/celeborn/pull/3757#discussion_r3559289574
##########
.github/workflows/deps.yml:
##########
@@ -81,24 +53,28 @@ jobs:
- 'flink-1.20'
- 'mr'
- 'tez'
+ exclude:
+ - tool: sbt
+ module: 'tez'
steps:
- - uses: actions/checkout@v4
- - name: Setup JDK 8
- uses: actions/setup-java@v4
- with:
- distribution: zulu
- java-version: 8
- cache: maven
- check-latest: false
- - name: Maven Check dependency list
- run: |
- ./dev/dependencies.sh --module ${{ matrix.module }} --check
+ - uses: actions/checkout@v4
+ - name: Setup JDK 8
+ uses: actions/setup-java@v4
+ with:
+ distribution: zulu
+ java-version: 8
+ cache: ${{ matrix.tool == 'maven' && 'maven' || '' }}
+ check-latest: false
+ - name: ${{ matrix.tool }} Check dependency list
+ run: |
+ ./dev/dependencies.sh ${{ matrix.tool == 'sbt' && '--sbt' || '' }}
--module ${{ matrix.module }} --check
- maven-jdk11:
+ jdk11:
Review Comment:
jdk11 jdk17 does not use sbt check, so some dependencies fail in sbt, here
use matrix to reduce some duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
