Deegue commented on code in PR #3756:
URL: https://github.com/apache/celeborn/pull/3756#discussion_r3584955559


##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/CongestionController.java:
##########
@@ -77,6 +82,7 @@ protected CongestionController(
     this.workerSource = workerSource;
     this.sampleTimeWindowSeconds = sampleTimeWindowSeconds;
     this.userInactiveTimeMills = 
conf.workerCongestionControlUserInactiveIntervalMs();
+    this.activePendingBytesCacheIntervalMs = 
conf.workerPinnedMemoryCheckIntervalMs();

Review Comment:
   The behavior of `trimMemoryUsage() ` is controlled by current 
workerCongestionControlCheckIntervalMs (default 10ms) which this PR doesn't 
change. 
   
   Pinned memory check interval is designed to follow 
`CelebornConf.WORKER_PINNED_MEMORY_CHECK_INTERVAL` according to comments above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to