Deegue opened a new pull request, #3756:
URL: https://github.com/apache/celeborn/pull/3756
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Change CongestionController.getTotalPendingBytes() from
MemoryManager.instance().getMemoryUsage() to
MemoryManager.instance().getPinnedMemory().
### Why are the changes needed?
getMemoryUsage() returns nettyUsedDirectMemory + sortMemory, which includes
Netty's pooled allocator overhead.
Change to getPinnedMemory() whcih returns nettyPinnedDirectMemory +
sortMemory instead.
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [x] Yes, the worker is supposed to resume when pending data drops below
the low watermark.
### Does this PR introduce _any_ user-facing change?
No API change.
Workers with congestion control will now correctly resume from congestion
state when actual pending data drops below the low watermark.
### How was this patch tested?
UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
