senthh commented on code in PR #3758: URL: https://github.com/apache/celeborn/pull/3758#discussion_r3613038926
########## charts/celeborn/files/conf/metrics.properties: ########## @@ -18,3 +18,6 @@ *.sink.prometheusServlet.class=org.apache.celeborn.common.metrics.sink.PrometheusServlet *.sink.jsonServlet.class=org.apache.celeborn.common.metrics.sink.JsonServlet *.sink.loggerSink.class=org.apache.celeborn.common.metrics.sink.LoggerSink + +# Expose metrics as JMX MBeans. Disabled by default; uncomment to enable. Review Comment: > Which version will this sink be enabled? @SteNicholas We tested this with 0.6.0 and 0.6.2; And hence this sink should be working for other 0.6* too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
