senthh commented on code in PR #3758: URL: https://github.com/apache/celeborn/pull/3758#discussion_r3623619942
########## charts/celeborn/files/conf/metrics.properties: ########## @@ -18,3 +18,6 @@ *.sink.prometheusServlet.class=org.apache.celeborn.common.metrics.sink.PrometheusServlet *.sink.jsonServlet.class=org.apache.celeborn.common.metrics.sink.JsonServlet *.sink.loggerSink.class=org.apache.celeborn.common.metrics.sink.LoggerSink + +# Expose metrics as JMX MBeans. Disabled by default; uncomment to enable. +# *.sink.jmx.class=org.apache.celeborn.common.metrics.sink.JmxSink Review Comment: Yes @SteNicholas ; Do you want me to un-comment below line? "# *.sink.jmx.class=org.apache.celeborn.common.metrics.sink.JmxSink" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
