Copilot commented on code in PR #3794:
URL: https://github.com/apache/celeborn/pull/3794#discussion_r3756284360
##########
cpp/CMakeLists.txt:
##########
@@ -337,9 +337,16 @@ if(APPLE)
INSTALL_RPATH
"@loader_path;${HOMEBREW_PREFIX}/lib;${HOMEBREW_PREFIX}/opt/openssl@3/lib"
BUILD_WITH_INSTALL_RPATH TRUE)
else()
+ # The version script alone is enough: it puts everything except celeborn::*
+ # and celeborn_* into the `local:` bucket. Do NOT add -Wl,--exclude-libs,ALL
Review Comment:
This comment says the version script localizes everything except
`celeborn::*` and `celeborn_*`, but `exports.map` also explicitly exports
`celeborn_ffi_*`. Including it here will keep the rationale accurate and
aligned with the actual version-script rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
