yugan95 commented on code in PR #3794:
URL: https://github.com/apache/celeborn/pull/3794#discussion_r3757705876
##########
cpp/CMakeLists.txt:
##########
@@ -337,9 +337,16 @@ if(APPLE)
INSTALL_RPATH
"@loader_path;${HOMEBREW_PREFIX}/lib;${HOMEBREW_PREFIX}/opt/openssl@3/lib"
BUILD_WITH_INSTALL_RPATH TRUE)
else()
+ # The version script alone is enough: it puts everything except celeborn::*
+ # and celeborn_* into the `local:` bucket. Do NOT add -Wl,--exclude-libs,ALL
Review Comment:
celeborn_ffi_* is already subsumed by the celeborn_* glob above it in
exports.map, so the effective export set is exactly celeborn::* + celeborn_* as
described. Leaving the comment as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
