Kalvin2077 opened a new pull request, #3809:
URL: https://github.com/apache/celeborn/pull/3809

   ### What changes were proposed in this pull request?
   
   Fix `TierWriter` buffer accounting and reference-count handling when 
`CompositeByteBuf.addComponent` fails before insertion or during consolidation. 
Add regression tests and include the shuffle key in write-error logs.
   
   ### Why are the changes needed?
   
   `addComponent` can fail before or after taking ownership of the buffer. 
Treating both cases identically can cause incorrect storage counters or buffer 
reference-count leaks.
   
   ### Does this PR resolve a correctness bug?
   
   - [x] Yes
   
   ### Does this PR introduce _any_ user-facing change?
   
   - [ ] Yes
   
   ### How was this patch tested?
   
   - Added tests for pre-insertion OOM, capacity overflow, and post-insertion 
consolidation OOM.
   - Ran `TierWriterSuite`: 11 tests passed.
   - Ran `./build/mvn spotless:check -pl worker`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to