Kalvin2077 commented on code in PR #3809:
URL: https://github.com/apache/celeborn/pull/3809#discussion_r3850939707
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriterSuite.scala:
##########
@@ -333,4 +385,162 @@ class TierWriterSuite extends AnyFunSuite with
BeforeAndAfterEach {
assert(fileLen == 10240)
assert(localTierWriter.closed === true)
}
+
+ test("memory tier writer should preserve state on composite buffer capacity
overflow") {
Review Comment:
Thx.
Added the suggested pre-insertion OOM regression test using a ByteBuf
wrapper that throws from readerIndex().
It verifies that the composite state, counters, file length, and caller ref
count remain unchanged.
The test fails with the old accounting behavior (+1024 bytes) and passes
with this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
