SparksFyz opened a new pull request, #3821:
URL: https://github.com/apache/celeborn/pull/3821
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
This pull request reports accurate per-partition size statistics for
Celeborn Tez shuffle output.
The main changes are:
- Retain the partition byte counters maintained by `DataPusher` in
`CelebornTezWriter`.
- Account for the bytes returned by `mergeData`.
- Use the same statistics source for ordered and unordered shuffle.
- Remove the incorrect `bytesPerPartition` counters from
`CelebornSortBasedPusher`.
- Preserve the existing behavior when partition statistics reporting is
disabled.
### Why are the changes needed?
The current Tez shuffle implementation reports incorrect partition
statistics:
- Ordered shuffle reports zero for every partition because the inherited
`partitionStats` array is never populated.
- Unordered shuffle reports the number of records instead of bytes because
`bytesPerPartition` is incremented once per record.
These incorrect statistics may affect Tez partition-size estimation and
reducer parallelism decisions.
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [ ] Yes
### How was this patch tested?
Added `CelebornTezWriterSuiteJ` to verify:
- Partition statistics snapshot behavior.
- `mergeData` accounting using the bytes returned by `ShuffleClient`.
- Asynchronous `pushData` accounting after the writer is closed.
- The close order of `DataPusher.waitOnTermination`, `pushMergedData`, and
`mapperEnd`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
