SteNicholas commented on code in PR #3821: URL: https://github.com/apache/celeborn/pull/3821#discussion_r3845130330
########## client-tez/tez/src/test/java/org/apache/celeborn/client/CelebornTezWriterSuiteJ.java: ########## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.client; + +import static org.junit.Assert.assertArrayEquals; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyInt; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.doAnswer; +import static org.mockito.Mockito.inOrder; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import java.util.concurrent.atomic.LongAdder; + +import org.junit.Test; +import org.mockito.InOrder; Review Comment: Could we add focused coverage for the two Tez consumers changed in this patch? This suite verifies the counters inside CelebornTezWriter, but it would still pass if CelebornSorter or CelebornUnorderedPartitionedKVWriter failed to expose the snapshot, or if disabled partition-stat reporting returned a non-null array. Exercising enabled and disabled TEZ_RUNTIME_REPORT_PARTITION_STATS through both paths would protect the user-visible behavior this PR is fixing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
