afterincomparableyum opened a new pull request, #3876:
URL: https://github.com/apache/celeborn/pull/3876
CELEBORN-2458 closes the channel when a push request times out. The other
pushes still outstanding on that channel are then failed by channelInactive
with "Connection from ... closed" (or by the write listener with "Failed to
send request ..."), which ExceptionUtils.connectFail maps to
PUSH_DATA_CONNECTION_EXCEPTION_PRIMARY/REPLICA. Those reports overwrite the
worker's PUSH_DATA_TIMEOUT_* entry in the excluded workers, misattributing a
worker that stopped responding as a connection failure, and make
PushDataTimeoutTest "pushdata timeout will add to pushExcludedWorkers" flaky.
Record the push timeout status before the timeout handler closes the channel
and use it for the remaining pushes failed on that channel.
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [ ] Yes
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
