zaynt4606 commented on code in PR #3876:
URL: https://github.com/apache/celeborn/pull/3876#discussion_r4311184835
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -139,15 +142,12 @@ public void failExpiredPushRequest() {
if (info.channelFuture != null) {
info.channelFuture.cancel(true);
}
+ if (timeoutStatus != null && info.hasTimeoutHandler()) {
Review Comment:
Could we set `pushTimeoutCloseStatus` before
`info.channelFuture.cancel(true)`? If the write future is still cancellable
(for example, its write is queued), cancellation completes it and notifies
`PushChannelListener`. That listener closes the channel on failure, so
`channelInactive()` can drain the other pushes before this assignment and still
report connection exceptions. The new test does not attach a `ChannelFuture` to
its expired request, so please cover this cancellation path as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
