venkata91 commented on PR #3859: URL: https://github.com/apache/celeborn/pull/3859#issuecomment-6284919815
Thanks for the review, @yew1eb! Addressed the comments in e560ac268: 1. Filed [CELEBORN-2490](https://issues.apache.org/jira/browse/CELEBORN-2490) and updated the PR title and description with the JIRA reference. 2. Changed `celeborn.worker.memoryFileStorage.replica.enabled` to default to `true`, preserving existing behavior after upgrade. Skipping memory for replicas now requires explicitly setting it to `false`. The configuration docs and PR description call out this compatibility decision; there is no longer a default storage-placement change. Any future proposal to change the default can be discussed separately with the community. 3. Aligned the debug log with the surrounding `partitionDataWriterContext.getPartitionLocation.getFileName` usage. 4. Documented that the setting also applies when a custom eviction policy targets MEMORY, and added regression coverage for that path. 5. Updated the tests to supply explicit `StorageInfo` with MEMORY and LOCAL_DISK availability, rather than relying on the implicit all-types default. Coverage now includes default and explicit replica settings, unchanged primary behavior, and custom eviction policies. Validation: all 13 storage-policy tests and 8 configuration-documentation tests passed on JDK 17; Spotless checks passed for common and worker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
