venkata91 commented on PR #3859: URL: https://github.com/apache/celeborn/pull/3859#issuecomment-6324670342
Thanks for the detailed reproduction, @zaynt4606! Addressed in ae509de73. Removed `MemoryManager.initialize(memoryConf)` and its configuration from the suite constructor. Each `createWriter` call now uses a scoped Mockito static mock of `MemoryManager.instance()`, returning a mock with `memoryFileStorageAvailable()` set to true. The static mock is closed in `finally`, including when writer creation throws. This suite no longer initializes or resets the shared singleton, and production code is unchanged. I reproduced the original JDK 17 failure with `MemoryManagerSuite` explicitly before `StoragePolicyReplicaSuite` (10 passed, 6 failed). With the fix, all 16 tests pass in both suite orders. All 21 tests also pass with `StoragePolicyCase1` through `StoragePolicyCase4` first, followed by `MemoryManagerSuite` and then `StoragePolicyReplicaSuite`. Worker Spotless checks pass. One separate pre-existing issue surfaced while varying the order: `StoragePolicyCase1` still initializes the singleton in its constructor and fails if it executes after `MemoryManagerSuite` resets it. In that ordering, all eight replica tests pass and Case1 is the sole failure. I left that existing fixture unchanged to keep this fix scoped to the new suite. CI still needs to confirm the supported-JDK matrix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
