[
https://issues.apache.org/jira/browse/CLOUDSTACK-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539655#comment-14539655
]
ASF GitHub Bot commented on CLOUDSTACK-8197:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/243#discussion_r30123116
--- Diff:
engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
---
@@ -62,9 +63,13 @@
static final String NetworkLockTimeoutCK = "network.lock.timeout";
static final String GuestDomainSuffixCK = "guest.domain.suffix";
static final String NetworkThrottlingRateCK =
"network.throttling.rate";
+ static final String MinVRVersionCK = "minreq.sysvmtemplate.version";
+
+ static final ConfigKey<String> MinVRVersion = new
ConfigKey<String>(String.class, MinVRVersionCK, "Advanced", "4.4.4",
--- End diff --
No, 4.4.2 is the minimum as some fixes went into the 4.4 branch. I don't
mind that instead of 4.4.4 that I did because I am an irritatingly formal guy.
> make minimal sysvm version configuratble
> ----------------------------------------
>
> Key: CLOUDSTACK-8197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8197
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, SystemVM
> Reporter: Daan Hoogland
> Assignee: Daan Hoogland
> Fix For: 4.6.0
>
>
> MinVRVersion is hard coded in the VirtualNetworkApplianceService. To
> facilitate users to make their own versions it must be a config key. As such
> it will be best to move it to NetworkOrchestrationService as it's use is
> mostly from that layer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
