[
https://issues.apache.org/jira/browse/CLOUDSTACK-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539656#comment-14539656
]
ASF GitHub Bot commented on CLOUDSTACK-8197:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/244#discussion_r30123159
--- Diff:
engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
---
@@ -62,9 +63,13 @@
static final String NetworkLockTimeoutCK = "network.lock.timeout";
static final String GuestDomainSuffixCK = "guest.domain.suffix";
static final String NetworkThrottlingRateCK =
"network.throttling.rate";
+ static final String MinVRVersionCK = "minreq.sysvmtemplate.version";
+
+ static final ConfigKey<String> MinVRVersion = new
ConfigKey<String>(String.class, MinVRVersionCK, "Advanced", "4.5.2",
--- End diff --
Fine
On Tue, 12 May 2015 12:54 Rohit Yadav <[email protected]> wrote:
> In
>
engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
> <https://github.com/apache/cloudstack/pull/244#discussion_r30122724>:
>
> > @@ -62,9 +63,13 @@
> > static final String NetworkLockTimeoutCK = "network.lock.timeout";
> > static final String GuestDomainSuffixCK = "guest.domain.suffix";
> > static final String NetworkThrottlingRateCK =
"network.throttling.rate";
> > + static final String MinVRVersionCK =
"minreq.sysvmtemplate.version";
> > +
> > + static final ConfigKey<String> MinVRVersion = new
ConfigKey<String>(String.class, MinVRVersionCK, "Advanced", "4.5.2",
>
> I guess all 4.5.x releases should support 4.5.0 as minimum VR version? so
> can we change this to 4.5.0?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/244/files#r30122724>.
>
> make minimal sysvm version configuratble
> ----------------------------------------
>
> Key: CLOUDSTACK-8197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8197
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, SystemVM
> Reporter: Daan Hoogland
> Assignee: Daan Hoogland
> Fix For: 4.6.0
>
>
> MinVRVersion is hard coded in the VirtualNetworkApplianceService. To
> facilitate users to make their own versions it must be a config key. As such
> it will be best to move it to NetworkOrchestrationService as it's use is
> mostly from that layer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
