[
https://issues.apache.org/jira/browse/CLOUDSTACK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636243#comment-14636243
]
ASF GitHub Bot commented on CLOUDSTACK-8596:
--------------------------------------------
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35181750
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -43,14 +45,14 @@
private ConfigurationDao _configDao;
@Inject
- private LdapManager _ldapManager;
+ private LdapConfigurationDao _ldapConfigurationDao;
public LdapConfiguration() {
}
- public LdapConfiguration(final ConfigurationDao configDao, final
LdapManager ldapManager) {
+ public LdapConfiguration(final ConfigurationDao configDao, final
LdapConfigurationDao ldapConfigurationDao) {
_configDao = configDao;
- _ldapManager = ldapManager;
+ _ldapConfigurationDao = ldapConfigurationDao;
--- End diff --
Why inject and pass on in the constructor. Do both have usage scenarios?
> [LDAP] Nested groups, ability of recursively querying nested groups
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-8596
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8596
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rajani Karuturi
> Assignee: Rajani Karuturi
>
> Nested group imports
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
