[
https://issues.apache.org/jira/browse/CLOUDSTACK-8596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636502#comment-14636502
]
ASF GitHub Bot commented on CLOUDSTACK-8596:
--------------------------------------------
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35191354
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFactory _ldapContextFactory;
@Inject
- private LdapUserManager _ldapUserManager;
+ private LdapConfiguration _ldapConfiguration;
+
+ @Inject LdapUserManagerFactory _ldapUserManagerFactory;
+
public LdapManagerImpl() {
super();
}
- public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManager ldapUserManager) {
+ public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManagerFactory ldapUserManagerFactory,
+ final LdapConfiguration ldapConfiguration) {
--- End diff --
It was initially done that way. We could inject as well. I did that in the
new class.
-----Original Message-----
From: "Daan Hoogland" <[email protected]>
Sent: 22-07-2015 13:18
To: "apache/cloudstack" <[email protected]>
Cc: "Rajani Karuturi" <[email protected]>
Subject: Re: [cloudstack] CLOUDSTACK-8596 ability to query nested groups
forMicrosoft AD (#609)
In
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java:
>
> public LdapManagerImpl() {
> super();
> }
>
> - public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManager ldapUserManager) {
> + public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManagerFactory ldapUserManagerFactory,
> + final LdapConfiguration ldapConfiguration) {
And why not use injection for that as well? Is this a groovy thing?
—
Reply to this email directly or view it on GitHub.
> [LDAP] Nested groups, ability of recursively querying nested groups
> -------------------------------------------------------------------
>
> Key: CLOUDSTACK-8596
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8596
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Rajani Karuturi
> Assignee: Rajani Karuturi
>
> Nested group imports
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
