[
https://issues.apache.org/jira/browse/CLOUDSTACK-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661293#comment-14661293
]
ASF GitHub Bot commented on CLOUDSTACK-8601:
--------------------------------------------
Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/547#discussion_r36490405
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -53,6 +53,7 @@
protected final SearchBuilder<StoragePoolVO> DcPodSearch;
protected final SearchBuilder<StoragePoolVO> DcPodAnyClusterSearch;
protected final SearchBuilder<StoragePoolVO> DeleteLvmSearch;
+ protected final SearchBuilder<StoragePoolVO> DcLocalStorageSearch;
--- End diff --
By convention, variables do not typically start with a capital letter.
I realize here that you are likely just doing that to fit in with the other
nearby code.
This might be a nice opportunity to rename all six of these member
variables to start with a lower-case version of the applicable letter (possibly
even prefixing them with an underscore as many people recognize that as a
convention for a member variable).
> VMFS storage added as local storage can be re added as shared storage.
> ----------------------------------------------------------------------
>
> Key: CLOUDSTACK-8601
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8601
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Likitha Shetty
> Assignee: Likitha Shetty
> Fix For: 4.6.0
>
>
> During host discovery, if local storage is enabled for a zone, all VMFS
> datastores that are mounted on just one host (i.e. not shared) will be added
> as local storage is CloudStack.
> When admin adds a VMFS datastore as shared, CS doesn't verify if the storage
> has already been added as local storage in the zone. This means the same
> primary storage is added as different storages in CS and this leads to
> failure in operations related to disks because of wrong storage look ups.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
