[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731206#comment-14731206
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8601:
--------------------------------------------

Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/547#issuecomment-137813369
  
    Hey...I just noticed something.
    
    I have a datastore that I manually added to my ESXi hosts (shared storage) 
that is based on an iSCSI target.
    
    When I restart the CS MS, this datastore (which I already added to 
CloudStack as shared primary storage) gets re-added as local storage (so it's 
listed as both shared and local primary storages).
    
    I think this is perhaps what lead to this pull-request in the first place, 
but the problem still exists.
    
    What happens now that this pull-request code is in is that the datastore 
conflict is detected and an error message is printed, but I still see my shared 
primary storage has been added as well as local storage.
    
    I'm looking into this more, but wanted to point out this observation.
    
    I had forgotten about this issue (I think it's pretty old). At the time, we 
put in a workaround where datastores that started with "-" or "_" were assumed 
to be shared and not re-added as local. It just happens that my manually added, 
shared datastore does not start with "-" or "_", so I see the problem.


> VMFS storage added as local storage can be re added as shared storage.
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8601
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8601
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Likitha Shetty
>            Assignee: Likitha Shetty
>             Fix For: 4.6.0
>
>
> During host discovery, if local storage is enabled for a zone, all VMFS 
> datastores that are mounted on just one host (i.e. not shared) will be added 
> as local storage is CloudStack.
> When admin adds a VMFS datastore as shared, CS doesn't verify if the storage 
> has already been added as local storage in the zone. This means the same 
> primary storage is added as different storages in CS and this leads to 
> failure in operations related to disks because of wrong storage look ups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to