[
https://issues.apache.org/jira/browse/CLOUDSTACK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699479#comment-14699479
]
ASF GitHub Bot commented on CLOUDSTACK-8721:
--------------------------------------------
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/673#discussion_r37183568
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ---
@@ -136,13 +136,13 @@ public String getInstanceName() {
return instanceName;
}
- public Map getDetails() {
+ public Map<String, String> getDetails() {
--- End diff --
The CommandType.MAP API args are usually map of object returning objects;
in practice AFAIR all map args are string->string. Either way, I don't
understand this change in getDetails(), this at least will result in returning
a new Map, so likely the author wants their details to be sort of read-only? If
so, why not use final?
> Setting details of VM through API results in removal of all other details
> except the one passed in API
> ------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8721
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8721
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
>
> Setting details of VM through API results in removal of all other details
> except the one passed in API. We are storing vm details which are not set by
> user and in this process of setting details all details are getting lost
> which could lead to other issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
