[
https://issues.apache.org/jira/browse/CLOUDSTACK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699480#comment-14699480
]
ASF GitHub Bot commented on CLOUDSTACK-8721:
--------------------------------------------
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/673#discussion_r37183610
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd)
throws ResourceUnavailableEx
}
if (details != null && !details.isEmpty()) {
- vmInstance.setDetails(details);
+ _vmDao.loadDetails(vmInstance);
--- End diff --
I think all we need is here, the side effect is that now users won't be
able to remove any details; only add/update details.
> Setting details of VM through API results in removal of all other details
> except the one passed in API
> ------------------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-8721
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8721
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Anshul Gangwar
> Assignee: Anshul Gangwar
>
> Setting details of VM through API results in removal of all other details
> except the one passed in API. We are storing vm details which are not set by
> user and in this process of setting details all details are getting lost
> which could lead to other issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
