[
https://issues.apache.org/jira/browse/CLOUDSTACK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699656#comment-14699656
]
ASF GitHub Bot commented on CLOUDSTACK-8736:
--------------------------------------------
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/707
Refactored Nic.java for readability.
Only changed names and reorganized them! No functional implementation
change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #707
----
commit 3ab7e477aa6c9a02db93344aaa36d00d231a3007
Author: Boris Schrijver <[email protected]>
Date: 2015-08-17T14:20:51Z
Refactored Nic.java for readability.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
commit 80bcfb12227080078cfa6760c0c4a9feb0dec51a
Author: Boris Schrijver <[email protected]>
Date: 2015-08-17T14:21:51Z
Changed methodnames according to Nic.java refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
commit af199e7057033a5c77b176ca1c2040f3d07ad16b
Author: Boris Schrijver <[email protected]>
Date: 2015-08-17T14:54:41Z
Fixed NicVO.java due to regression from Nic.java refactor.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
----
> Refactor network code
> ---------------------
>
> Key: CLOUDSTACK-8736
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8736
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, Network Devices
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
> Priority: Minor
>
> Over the years after many code additions, changes and/or removals the network
> code has become obfuscated. Multiple getters/setters exist for the same
> variable, order and structure is missing, variable naming is not consistent,
> no clear difference exists between IPv4 and IPv6 code, and so on.
> This ticket exist to be referenced to by PRs which includes refactors of
> network classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
