[
https://issues.apache.org/jira/browse/CLOUDSTACK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702491#comment-14702491
]
ASF subversion and git services commented on CLOUDSTACK-8736:
-------------------------------------------------------------
Commit ef783d9b1de3954f50ba5c61197a5acc1631c6fe in cloudstack's branch
refs/heads/master from [~rajanik]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef783d9 ]
Merge pull request #707 from borisroman/CLOUDSTACK-8736
Refactored Nic.java for readability.Only changed names and reorganized them! No
functional implementation change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
* pr/707:
Renamed internal variables of NicProfile.java to adhere to the naming
convention.
Refactored Nic.java for readability.
Signed-off-by: Rajani Karuturi <[email protected]>
> Refactor network code
> ---------------------
>
> Key: CLOUDSTACK-8736
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8736
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Network Controller, Network Devices
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
> Priority: Minor
>
> Over the years after many code additions, changes and/or removals the network
> code has become obfuscated. Multiple getters/setters exist for the same
> variable, order and structure is missing, variable naming is not consistent,
> no clear difference exists between IPv4 and IPv6 code, and so on.
> This ticket exist to be referenced to by PRs which includes refactors of
> network classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
