[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731225#comment-14731225
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8601:
--------------------------------------------

Github user mike-tutkowski commented on the pull request:

    https://github.com/apache/cloudstack/pull/547#issuecomment-137816807
  
    Here is the relevant code (in HostMO.java):
    
        public List<Pair<ManagedObjectReference, String>> 
getLocalDatastoreOnHost() throws Exception {
            List<Pair<ManagedObjectReference, String>> dsList = new 
ArrayList<Pair<ManagedObjectReference, String>>();
    
            ObjectContent[] ocs = getDatastorePropertiesOnHyperHost(new 
String[] {"name", "summary"});
            if (ocs != null) {
                for (ObjectContent oc : ocs) {
                    DatastoreSummary dsSummary = 
(DatastoreSummary)VmwareHelper.getPropValue(oc, "summary");
                    if (dsSummary.isMultipleHostAccess() == false && 
dsSummary.isAccessible() && dsSummary.getType().equalsIgnoreCase("vmfs")) {
                        ManagedObjectReference morDs = oc.getObj();
                        String name = (String)VmwareHelper.getPropValue(oc, 
"name");
    
                        if (!name.startsWith("-iqn.") && 
!name.startsWith("_iqn.")) {
                            dsList.add(new Pair<ManagedObjectReference, 
String>(morDs, name));
                        }
                    }
                }
            }
            return dsList;
        }


> VMFS storage added as local storage can be re added as shared storage.
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8601
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8601
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Likitha Shetty
>            Assignee: Likitha Shetty
>             Fix For: 4.6.0
>
>
> During host discovery, if local storage is enabled for a zone, all VMFS 
> datastores that are mounted on just one host (i.e. not shared) will be added 
> as local storage is CloudStack.
> When admin adds a VMFS datastore as shared, CS doesn't verify if the storage 
> has already been added as local storage in the zone. This means the same 
> primary storage is added as different storages in CS and this leads to 
> failure in operations related to disks because of wrong storage look ups.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to