[
https://issues.apache.org/jira/browse/CLOUDSTACK-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741859#comment-14741859
]
ASF GitHub Bot commented on CLOUDSTACK-8817:
--------------------------------------------
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139703362
Okay that makes sense. I went through the entire project and found only one
caller of setStartPort and setEndPort which was from the relevant
class(Firewall Response). There were others, but they were referring to a
different class. The relevant caller took an argument of the form x.toString
previously, but now since I changed the setter definition and the variable
types to Integer, I removed the .toString part since it was already an Integer
being converted to a String. There was no getter definition at all in
FirewallResponse.java. Should I go ahead and commit? Also, in what way should I
adjust the comments on my commit like you mentioned?
Thanks for the help!
> listFirewallRules response JSON startport/endport not an int
> ------------------------------------------------------------
>
> Key: CLOUDSTACK-8817
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8817
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: API
> Affects Versions: 4.6.0
> Reporter: René Moser
> Priority: Trivial
>
> h2. Summary
> listFirewallRules returns endpoint and startpoint values as String.
> h2. Excpected results
> {code}
> {
> "count": 1
> "firewallrule": [
> {
> "cidrlist": "0.0.0.0/0",
> "endport": 22,
> "fordisplay": true,
> "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03",
> "ipaddress": "10.101.0.21",
> "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21",
> "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a",
> "protocol": "tcp",
> "startport": 22,
> "state": "Active",
> "tags": []
> }
> ]
> }
> {code}
> h2. Actuall results
> {code}
> {
> "count": 1
> "firewallrule": [
> {
> "cidrlist": "0.0.0.0/0",
> "endport": "22",
> "fordisplay": true,
> "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03",
> "ipaddress": "10.101.0.21",
> "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21",
> "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a",
> "protocol": "tcp",
> "startport": "22",
> "state": "Active",
> "tags": []
> }
> ]
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
