[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742641#comment-14742641
 ] 

ASF subversion and git services commented on CLOUDSTACK-8817:
-------------------------------------------------------------

Commit 120e1cc934815ad9a58c4b5e89f5222251114bb3 in cloudstack's branch 
refs/heads/master from [~widodh]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=120e1cc ]

Merge pull request #810 from ashwinswaroop/feature_x

This is the fix for the JIRA issue CLOUDSTACK-8817.This is my first 
contribution to Apache CloudStack. The return values for endpoint and 
startpoint have now been changed to Integer instead of String. Please let me 
know if this is the only change that is required or if there are additional 
files which will be impacted by this change which require modification also.

* pr/810:
  CLOUDSTACK-8817: listFirewallRules response JSON startport/endport not an int
  This is the fix for the JIRA issue CLOUDSTACK-8817. The return values for 
endpoint and startpoint are now Integer instead of String.

Signed-off-by: Wido den Hollander <[email protected]>


> listFirewallRules response JSON startport/endport not an int
> ------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8817
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8817
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: API
>    Affects Versions: 4.6.0
>            Reporter: René Moser
>            Priority: Trivial
>
> h2. Summary
> listFirewallRules returns endpoint and startpoint values as String.
> h2. Excpected results
> {code}
> {
>   "count": 1 
>   "firewallrule": [
>     {
>       "cidrlist": "0.0.0.0/0", 
>       "endport": 22, 
>       "fordisplay": true, 
>       "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03", 
>       "ipaddress": "10.101.0.21", 
>       "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21", 
>       "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a", 
>       "protocol": "tcp", 
>       "startport": 22, 
>       "state": "Active", 
>       "tags": []
>     }
>   ]
> }
> {code}
> h2. Actuall results
> {code}
> {
>   "count": 1 
>   "firewallrule": [
>     {
>       "cidrlist": "0.0.0.0/0", 
>       "endport": "22", 
>       "fordisplay": true, 
>       "id": "126dccd4-ed9a-42a5-bd25-204aab8c8f03", 
>       "ipaddress": "10.101.0.21", 
>       "ipaddressid": "c70e7a84-4fa2-40a0-a70d-f64101663f21", 
>       "networkid": "b0c50de4-015e-4b28-a12a-8955698ebc2a", 
>       "protocol": "tcp", 
>       "startport": "22", 
>       "state": "Active", 
>       "tags": []
>     }
>   ]
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to