[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743169#comment-14743169
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8827:
--------------------------------------------

Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/793#issuecomment-140003171
  
    @anshul1886 I do not agree to your statement and hence I already tried to 
explain what you can test in this piece of code. If you still dont get it(or 
dont want to understand it) I cannot explain. 
     I really dont understand why you dont see a value in unittests. I dont 
want to explain the benefits of unit testing here (I neither have time nor do I 
have belief that you will understand). 
    
    Please add a marvin test on what you are achieving by this change. As much 
as possible, we need an automated way to test new code. 
    
    Also, add information what tests you already performed to ensure the code 
works.


> VM snapshot stuck in Creating state when management service is stopped
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8827
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8827
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>             Fix For: 4.6.0
>
>
> If we stop cloudstack-managment service while a VM snapshot is in progress, 
> the snapshot will be stuck in "Creating" state forever, even after the 
> service is started.
> This will leave the snapshot in unusable state (we can't delete it or it 
> won't go into Error state etc).
> Repro steps:
> ==========
> Create an instance.
> Take a VM snapshot and stop the cloudstack-managment service while the 
> snapshot is in progress.
> Check the snapshot state in DB and it will be creating.
> Start the management service and check the snapshot state.
> It will be creating forever.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to