[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910067#comment-14910067
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8827:
--------------------------------------------

Github user anshul1886 commented on the pull request:

    https://github.com/apache/cloudstack/pull/793#issuecomment-143647389
  
    Rebased the PR to current master.
    
    Regarding unit tests, method doesn't have input or output as a unit. It has 
output only in terms of DB updation so for me useful unit tests for these 
methods can not be written.
    
    
http://www.petrikainulainen.net/programming/testing/writing-tests-for-data-access-code-unit-tests-are-waste/



> VM snapshot stuck in Creating state when management service is stopped
> ----------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-8827
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8827
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Anshul Gangwar
>            Assignee: Anshul Gangwar
>             Fix For: 4.6.0
>
>
> If we stop cloudstack-managment service while a VM snapshot is in progress, 
> the snapshot will be stuck in "Creating" state forever, even after the 
> service is started.
> This will leave the snapshot in unusable state (we can't delete it or it 
> won't go into Error state etc).
> Repro steps:
> ==========
> Create an instance.
> Take a VM snapshot and stop the cloudstack-managment service while the 
> snapshot is in progress.
> Check the snapshot state in DB and it will be creating.
> Start the management service and check the snapshot state.
> It will be creating forever.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to