[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876266#comment-14876266
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39895353
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -19,31 +19,45 @@
package com.cloud.agent.api.element;
+import com.cloud.agent.api.Command;
+
import java.util.List;
import java.util.Map;
-import com.cloud.agent.api.Command;
-
public class ApplyAclRuleVspCommand extends Command {
+ boolean _networkAcl;
String _networkUuid;
String _networkDomainUuid;
String _vpcOrSubnetUuid;
- boolean _isL3Network;
+ String _networkName;
+ boolean _isL2Network;
List<Map<String, Object>> _aclRules;
- boolean _isVpc;
long _networkId;
+ boolean _egressDefaultPolicy;
+ Boolean _acsIngressAcl;
+ boolean _networkReset;
+ String _domainTemplateName;
--- End diff --
Why aren't these attributes declared ``private``?
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
