[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876273#comment-14876273
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39895682
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -33,16 +34,23 @@
String _networkName;
String _networkCidr;
String _networkGateway;
+ Long _networkAclId;
+ List<String> _dnsServers;
+ List<String> _gatewaySystemIds;
String _networkUuid;
boolean _isL3Network;
+ boolean _isVpc;
+ boolean _isSharedNetwork;
String _vpcName;
String _vpcUuid;
boolean _defaultEgressPolicy;
- Collection<String> _ipAddressRange;
+ Collection<String[]> _ipAddressRange;
+ String _domainTemplateName;
public ImplementNetworkVspCommand(String networkDomainName, String
networkDomainPath, String networkDomainUuid, String networkAccountName, String
networkAccountUuid,
- String networkName, String networkCidr, String networkGateway,
String networkUuid, boolean isL3Network, String vpcName, String vpcUuid,
boolean defaultEgressPolicy,
- Collection<String> ipAddressRange) {
+ String networkName, String networkCidr, String networkGateway,
Long networkAclId, List<String> dnsServers, List<String> gatewaySystemIds,
String networkUuid,
+ boolean isL3Network, boolean isVpc, boolean isSharedNetwork,
String vpcName, String vpcUuid, boolean defaultEgressPolicy,
Collection<String[]> ipAddressRange,
+ String domainTemplateName) {
--- End diff --
The number of parameters is extremely large -- creating a brittle interface
and difficult to comprehend client client. Please refactor to the Builder
pattern (i.e. declare the builder a ``public static final`` inner class to
create instances of ``ImplementNetworkVspCommand`` and declare the constructor
of ``ImplementNetworkVspCommand`` ``private``).
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
