[
https://issues.apache.org/jira/browse/CLOUDSTACK-8832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876352#comment-14876352
]
ASF GitHub Bot commented on CLOUDSTACK-8832:
--------------------------------------------
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39898685
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -129,6 +145,18 @@
AgentManager _agentMgr;
@Inject
NetworkOfferingDao _ntwkOfferingDao;
+ @Inject
+ ConfigurationDao _configDao;
+ @Inject
+ NuageVspManager _nuageVspManager;
+ @Inject
+ FirewallRulesDao _firewallRulesDao;
+ @Inject
+ FirewallRulesCidrsDao _firewallRulesCidrsDao;
+ @Inject
+ PhysicalNetworkDao _physicalNetworkDao;
+ @Inject
+ NetworkACLItemDao _networkACLItemDao;
@Override
public boolean applyIps(Network network, List<? extends
PublicIpAddress> ipAddress, Set<Service> service) throws
ResourceUnavailableException {
--- End diff --
This method is incredibly long and performing many different operations.
Decompose into a smaller private/utility methods and possibly consider some
small ValueObjects. Each of these methods should have a set of unit tests to
verify them.
> Update Nuage VSP plugin to work with Nuage VSP release 3.2
> ----------------------------------------------------------
>
> Key: CLOUDSTACK-8832
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8832
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
> Affects Versions: 4.6.0
> Reporter: Nick Livens
> Assignee: Nick Livens
>
> Nuage VSP 3.2 is being released, we want to bring the plugin up to date for
> this release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
